Needs Triage Bug Report - Chat

What type of bug are you reporting? Chat

What is the bug?
/ds ranges mistakenly giving redundant error

Are you able to replicate it? If so, how?
Happens with:
- /ds stat>number,sameStat>biggerNumber|anyParam
- /ds stat<number,sameStat<smallerNumber|anyParam
These searches work in /ms and used to work in /ds, but now, the following error is displayed: "The search already included '[the second stat range]' or another inequality which makes it redundant." (This might be because it would be redundant if it didn't have |anyParam.)
Example: /ds atk>100,atk>170|lc (without the error, it would show: Cranidos, Deoxys-Attack)

I rumor that this is what led to the bug:
https://github.com/smogon/pokemon-showdown/commit/7d989abe8e614207aeea3d69913f1e1889c4c67d
"Error on duplicates, invalid ranges, and muliple inequality operators"
 
While I was implementing the feature to allow comparison directly between stats similar sorts of searches were described as undesirable. Looks like it was made too strict, I can make it ignore the redundant search error when one of the conflicting inequalities is ORed together with another param.
 
Last edited:
Back
Top