Mechanics Mega Rayquaza Clause overrides Terastal Clause

[Nintenbox#0731]

What type of bug are you reporting? Mechanics

What is the bug?
When the Mega Rayquaza Clause is combined with the Terastal Clause, Rayquaza can still Terastalize. This is due to a line in the code in the Mega Rayquaza Clause that fixes what I presume to be Rayquaza being unable to Tera with the clause active. Removing the "pokemon.canTerastalize = this.actions.canTerastalize(pokemon);" from the code for the MegaRay Clause fixes the issue.

If the current suspect test in National Dex Ubers ends with a vote to ban Tera, this might be of relevance. Apologies if this is something that the coders were already aware of.

Are you able to replicate it? If so, how?
https://replay.pokemonshowdown.com/...nubers-3103-exuy26ie4a8w23wy06x6xxw6l21g2alpw

 

[urkerab]

Unfortunately it's not that simple: when you ban MRay and allow Tera, Rayquaza should be allowed to Tera; removing that line would prevent that.

 

[Nintenbox#0731]

Unfortunately it's not that simple: when you ban MRay and allow Tera, Rayquaza should be allowed to Tera; removing that line would prevent that.

Would a separate MegaRay clause have to be implemented if Tera gets banned from NDUbers?

 

[urkerab]

As a workaround, it seems that if you list the Terastal Clause before the Mega Rayquaza Clause then Rayquaza is able to Terastallise but if you list the Mega Rayquaza Clause before the Terastal Clause then it won't be able to.

 

[Oculars]

After some testing it appears that if tera goes in NDUBers they're going to need to reorder the clauses in the metagames code, urkerabs workaround seems to fix this issue. Tagging ndubers leaders to let u know of this bug entrocefalo Bobsican

 

[Bobsican]

Would probably be best to hold this until the ND Ubers suspect on Tera is done, to avoid having to potentially do twice as much maintenance on the same issue.

Edit: After further looking around, this appears to be irrelevant to the above as it'll work the same, nevermind, this should be good to go as long it doesn't change the practical mechanics of ND Ubers (aka, Rayquaza can still Terastallize over there).