Done Gen 4-5: Frisk Pokemon is wrongly given as holder of identified item

[DonBoneJones]

What type of bug are you reporting? Random Battles

What is the bug?
Banette frisked a Dewgong's Damp Rock, and PS! mistakenly showed Banette to be holding the Damp Rock when hovering over Banette's sprite. Obviously it can't get Damp Rock in randbats.

https://replay.pokemonshowdown.com/gen4randombattle-2250804597-6yvgixjxftdgkektjhxrkpdtb54xv21pw?p2

the bug in question

Are you able to replicate it? If so, how?
This has happened multiple times on ladder, I don't recall if it was just with Damp Rock or if other items also cause this to happen.
Update: this bug happens with all items, not just damp rock.

 

[Mathy]

While at first glance it looks like a client-side bug, it's actually a consequence of #10453 not following message protocol. It sends |-item|p1a: Banette|Damp Rock|[from] ability: Frisk|[of] p1a: Banette which wrongly implies that Banette is the one holding the Damp Rock.

 

[urkerab]

In Gens 4-5 Doubles, Frisk doesn't reveal which foe holds the item, so it would be wrong for the protocol to send the holder of the item.

 

[Mathy]

Fixed -- server#10695 and client#2302